SwissCenter - Re: ofdb.de parser


SwissCenter

Main Menu

No account yet? Create one

Home

Forums

SwissCenter Forums

home | post reply | threaded view | help

Boardwalk :: Forum List

SwissCenter

Bugs Reports

semko
User

Posts: 26

ofdb.de parser - 2008/09/11 07:52 There is a little bug in the current ofdb.de script. When a match is found but the resulting page does not contain a synopsis ('Inhalt:' is missing), some random text from who-knows-where is parsed to the synopsis field.

Sem Player: Pinnacle ShowCenter 200
Server: Windows XP Pro SP3 (Simese 1.45, SwissCenter latest SVN)

| | The administrator has disabled public write access.

KMan
User

Posts: 52

Re: ofdb.de parser - 2008/09/11 08:54 Hi!

i can confirm this behaviour, same here

Player : Pinnacle ShowCenter 250HD (wired)
Server : XP Pro SP2+ (Simese 1.45, SwissCenter current SVN)
Spec : Intel Pentium D830 (DualCore) 3GHz, 2GB RAM

| | The administrator has disabled public write access.

Pernod

Admin

Posts: 1504

Re: ofdb.de parser - 2008/09/11 09:29 Please provide an example to test with. Player : Netgear EVA700 & Popcorn A-100 (081224)
Server : Vista SP1 Home Premium (Simese 2.06, SwissCenter current SVN)
Spec : Intel C2Q Q6600, 2GB RAM, 2Tb storage.

| | The administrator has disabled public write access.

KMan
User

Posts: 52

Re: ofdb.de parser - 2008/09/11 10:44 Hi,

e.g. American Crude ofdb entry returns synopsis like Auf einen Mythos blickt man im Prinzip aus weiter Ferne, aber, ich glaube, beim Sehen von "The Dark Knight" ist man ganz nah dran; als wäre man Zeuge von der Geburt eines Sternes im All; von etwas Großem jedenfalls... [mehr] which roughly translates to seeing the dark knight is a big event, and obviously has nothing to do with American Crude

btw, after a quick look: all items without synopsis have this certain text

Hope this helps Player : Pinnacle ShowCenter 250HD (wired)
Server : XP Pro SP2+ (Simese 1.45, SwissCenter current SVN)
Spec : Intel Pentium D830 (DualCore) 3GHz, 2GB RAM

| | The administrator has disabled public write access.

semko
User

Posts: 26

Re: ofdb.de parser - 2008/09/11 10:49 Here's another one:

Der Hades-Faktor

Sem Player: Pinnacle ShowCenter 200
Server: Windows XP Pro SP3 (Simese 1.45, SwissCenter latest SVN)

| | The administrator has disabled public write access.

grovve
User

Posts: 101

Re: ofdb.de parser - 2008/09/11 10:57 I have this problems as well. The wrong synopsis was always taken from a film I already have in my DB, however it changes after a couple of updates.

- Chris Player : NMT A-100 "Popcorn Hour"
Server : Debian Linux 2.6.24, XAMPP, SwissCenter 1.21, TwonkyMedia UPnP Server
Specs: PIII 700 MHz, 576 MB RAM, 2.5 TB Storage
Network: MSI ePower 200AV Powerline Adapters

| | The administrator has disabled public write access.

KMan
User

Posts: 52

Re: ofdb.de parser - 2008/09/23 10:06 o.k. Guys,

i know what goes wrong, and how this could, in theory, be fixed...
but i need someone (Nigel

to do it...

When there is no Synopsis on an ofdb page there is no Inhalt: on it, which causes the parser at this point

Code:


       // Synopsis
      $start = strpos($html,"Inhalt:");
      $end = strpos($html,"</tr>",$start+1);

to return the upper part of the page, the link that is got by the parser from there is always http://www.ofdb.de/view.php?page=start, from there the search for a synopsis always result in the text from Unser aktueller Review-Tip and that is why it changes after a while.

From my understanding this could easily be fixed by checking if the $start in the code above has a result greater then 'not found' (how ever this is in php, i would guess -1?) and if not, just skip the synopsis part.

Hope this helps ?

@Pernod, write something, i never know if you got what i wrote

Player : Pinnacle ShowCenter 250HD (wired)
Server : XP Pro SP2+ (Simese 1.45, SwissCenter current SVN)
Spec : Intel Pentium D830 (DualCore) 3GHz, 2GB RAM

| | The administrator has disabled public write access.

KMan
User

Posts: 52

Re: ofdb.de parser - 2008/09/23 15:53 @Pernod, can you confirm my theory here ?

Kind regards

KMan Player : Pinnacle ShowCenter 250HD (wired)
Server : XP Pro SP2+ (Simese 1.45, SwissCenter current SVN)
Spec : Intel Pentium D830 (DualCore) 3GHz, 2GB RAM

| | The administrator has disabled public write access.

Pernod

Admin

Posts: 1504

Re: ofdb.de parser - 2008/09/23 20:20 Yes your theory is correct.

Can you test the attached before I submit it.

File Attachment:
File name: www.ofdb.de_fix_inhalt.zip
File size:2292 bytes

Player : Netgear EVA700 & Popcorn A-100 (081224)
Server : Vista SP1 Home Premium (Simese 2.06, SwissCenter current SVN)
Spec : Intel C2Q Q6600, 2GB RAM, 2Tb storage.

| | The administrator has disabled public write access.

KMan
User

Posts: 52

Re: ofdb.de parser - 2008/09/24 06:44 Hi Pernod!

Tested and its working correctly now.
while you are at it what do you think of my idea for the lookup that i posted ?
-- taken from my post ->

Code:


     $search_url   = 'http://www.google.de/search?q=allintitle%3A#####+-review+site%3Aofdb.de&filter=0';

this may but most likely will not have side effects that i am currently not aware of, but at least this solved all issues which i had with titles from my db.

it narrows googles results by excluding all pages that have review in their title and only show matches that have all words from the movietitle in the page title aswell. Additionally it avoids that google filters matches because of simular content.

Hope this helps?

Kind regards

KMan

P.S.: could you use the language file i posted a while ago ? Player : Pinnacle ShowCenter 250HD (wired)
Server : XP Pro SP2+ (Simese 1.45, SwissCenter current SVN)
Spec : Intel Pentium D830 (DualCore) 3GHz, 2GB RAM

| | The administrator has disabled public write access.

Pernod

Admin

Posts: 1504

Re: ofdb.de parser - 2008/09/24 07:31 Your Google query makes sense, but I'm hesitant to change it unless it really makes a difference as the existing query was extensively tested in the past. Don't want to change it if it's not broken.

You language changes will be submiited at some point. I have 50+ files to submit from my development version (fixes, changes, new features) and very little time available. Player : Netgear EVA700 & Popcorn A-100 (081224)
Server : Vista SP1 Home Premium (Simese 2.06, SwissCenter current SVN)
Spec : Intel C2Q Q6600, 2GB RAM, 2Tb storage.

| | The administrator has disabled public write access.

KMan
User

Posts: 52

Re: ofdb.de parser - 2008/09/24 08:35 Pernod wrote:
... I'm hesitant to change it unless it really makes a difference...

i tested with most of my database and it defenatly made a difference, i tested with all prior unmatched entries, which now all got matched and several before already matched which still worked as expected.

why not provide a test version which german users could test more extensively, and if feedback is positive change it then ?

You language changes will be submiited at some point. I have 50+ files to submit from my development version (fixes, changes, new features) and very little time available.

n.p.
it's only hard to tell if you noticed a post like that, when you lack the time to reply. But nevertheless i do understand your time issue very well. Player : Pinnacle ShowCenter 250HD (wired)
Server : XP Pro SP2+ (Simese 1.45, SwissCenter current SVN)
Spec : Intel Pentium D830 (DualCore) 3GHz, 2GB RAM

| | The administrator has disabled public write access.

Boardwalk :: Forum List SwissCenter Bugs Reports

Simpleboard Forum Component 1.1.0 Stable
Two Shoes Mambo Factory

Screenshots

www.flickr.com

This is a Flickr badge showing public photos from swisscenter. Make your own badge here.

Mambo is Free Software released under the GNU/GPL License.